Skip to content

Fix gitmodules handling for clone command #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Kinokin
Copy link

@Kinokin Kinokin commented Jul 25, 2022

  • handle relative submodule url
  • handle special branch '.'

Kinokin added 2 commits July 25, 2022 09:29
Change-Id: I6de67e5961cd1ff8a8d72e741d23c7c78bb8c7b3
Change-Id: Ie3422c05529497bfa3cf1d99ec33227f418c8996
@Reedbeta
Copy link
Owner

Thanks for the PR! I think the code can likely be simplified a lot using os.path.relpath and such rather than parsing the path yourself. See how I'm doing it for the submodule paths a few lines earlier:

submoduleRelPathsToProcess = [os.path.relpath(os.path.abspath(path), worktreeRoot)

Also, it looks like you used 3-space indents instead of 4 - I'd appreciate if you can clean that up. 🙂

@Kinokin
Copy link
Author

Kinokin commented Jul 26, 2022

Hi Nathan, yes, its a quick hack to get an experiment working. I can't spend any more time on this, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants