Skip to content

Conversation

lantiga
Copy link
Contributor

@lantiga lantiga commented Jul 21, 2020

Addresses #434

@lantiga lantiga requested a review from gkorland July 21, 2020 12:26
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #435 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #435   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files          21       21           
  Lines        4504     4504           
=======================================
  Hits         3287     3287           
  Misses       1217     1217           
Impacted Files Coverage Δ
src/redisai.c 78.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b9d72...24a2cc8. Read the comment docs.

@gkorland
Copy link
Contributor

@lantiga I don't see where you call RedisModule_KeyAtPos and RedisModule_IsKeysPositionRequest

@lantiga
Copy link
Contributor Author

lantiga commented Jul 22, 2020

You are right, my bad.
After further consideration though, we will need to defer this to after merging #424: in the new DAGRUN PR we factor out parsing all kets before blocking, which makes it a lot easier to implement the missing functions.

@lantiga
Copy link
Contributor Author

lantiga commented Jul 22, 2020

In scope: #160 #161

@filipecosta90
Copy link
Collaborator

closing this one in favor of #438 , which already addresses this issue for MODELRUN, DAGRUN, and SCRIPTRUN

@filipecosta90 filipecosta90 deleted the getkeys-api-fix branch August 6, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants