Skip to content

Conversation

@bingeng99
Copy link

[fix] the parameters LANGUAGE is not supported in the FT.SEARCH

@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #29 into master will increase coverage by 1.53%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   61.85%   63.39%   +1.53%     
==========================================
  Files          12       12              
  Lines         894      896       +2     
==========================================
+ Hits          553      568      +15     
+ Misses        277      270       -7     
+ Partials       64       58       -6
Impacted Files Coverage Δ
redisearch/query.go 86.23% <100%> (+12.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96bd878...5e9b094. Read the comment docs.

@filipecosta90
Copy link
Collaborator

@bingeng99 you're totally right. adding the reference doc:
https://oss.redislabs.com/redisearch/Commands.html#ftsearch
Also, I think we should take the query_test.go test file and add a test case specifically named 'TestQuery_serialize'. Will submit a PR that will add testing for the serialize method. Afterward, when that testing addition PR is merged, I think you should expand that same test with the Language addition ( so that codecov test passes). What do you think?

@bingeng99
Copy link
Author

@filipecosta90 I have added test cases for query serialize method.

@filipecosta90
Copy link
Collaborator

@filipecosta90 I have added test cases for query serialize method.

thanks @bingeng99
LGTM 👍

@filipecosta90 filipecosta90 merged commit f0362cd into RediSearch:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants