Develop #14
Merged
Develop #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this too? |
|
Sure. I've just pushed some code that checks if the delete function is working as expected. |
mnunberg
reviewed
Apr 14, 2019
redisearch/redisearch_test.go
Outdated
| "time" | ||
|
|
||
| "github.com/RediSearch/redisearch-go/redisearch" | ||
| "github.com/mibes/redisearch-go/redisearch" |
There was a problem hiding this comment.
Good catch! Should be fixed now.
|
Looks good. Please fix the package import and I'll merge. Thanks for the contribution! |
|
@mnunberg/ @mibes is there anything left on this PR that I can do/ help with in order to get it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For one of our projects we needed the ability to delete documents from an existing index. This extension wraps the "FT.DEL" command with the optional "DD" flag.