Skip to content

Issue 100 ft.info #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 22, 2021
Merged

Issue 100 ft.info #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45d50e7
issue #100 ft.info user friendly , post 3.3.0
tgrall Jun 17, 2020
caaecb5
Merge branch 'master' into issue-100-ft.info
tgrall Oct 17, 2020
3868ba5
Merge branch 'master' into issue-100-ft.info
tgrall Jan 8, 2021
6d0e670
move to jedis 3.4.1 and update test for getinfo - issue #100
tgrall Jan 10, 2021
1cc5333
Format code
sazzad16 Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
<dependency>
<groupId>redis.clients</groupId>
<artifactId>jedis</artifactId>
<version>3.3.0</version>
<version>3.4.1</version>
</dependency>
</dependencies>

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/io/redisearch/client/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ private static void handleListMapping(List<Object> items, KVHandler handler, boo
for (int i = 0; i < items.size(); i += 2) {
String key = SafeEncoder.encode((byte[]) items.get(i));
Object val = items.get(i + 1);
if (decode && val instanceof byte[]) {
val = SafeEncoder.encode((byte[]) val);
if (decode /*&& val instanceof byte[]*/) {
val = SafeEncoder.encodeObject(val);
}
handler.apply(key, val);
}
Expand Down
25 changes: 22 additions & 3 deletions src/test/java/io/redisearch/client/ClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,8 +522,8 @@ public void testAlterAdd() throws Exception {

Map<String, Object> info = cl.getInfo();
assertEquals(TEST_INDEX, info.get("index_name"));
assertEquals("tags", SafeEncoder.encode(((List<List<byte[]>>)info.get("fields")).get(1).get(0)));
assertEquals("TAG", SafeEncoder.encode(((List<List<byte[]>>)info.get("fields")).get(1).get(2)));
assertEquals("tags",((List)((List)info.get("fields")).get(1)).get(0));
assertEquals("TAG", ((List)((List)info.get("fields")).get(1)).get(2));
}

@Test
Expand Down Expand Up @@ -581,12 +581,31 @@ public void testPhoneticMatch() throws Exception {
public void testInfo() throws Exception {
Client cl = getClient();

Schema sc = new Schema().addTextField("title", 1.0);
String MOVIE_ID = "movie_id";
String TITLE = "title";
String GENRE = "genre";
String VOTES = "votes";
String RATING = "rating";
String RELEASE_YEAR = "release_year";
String PLOT = "plot";
String POSTER = "poster";

Schema sc = new Schema()
.addTextField(TITLE, 5.0)
.addSortableTextField(PLOT, 1.0)
.addSortableTagField(GENRE, ",")
.addSortableNumericField(RELEASE_YEAR)
.addSortableNumericField(RATING)
.addSortableNumericField(VOTES);

assertTrue(cl.createIndex(sc, Client.IndexOptions.defaultOptions()));

Map<String, Object> info = cl.getInfo();
assertEquals(TEST_INDEX, info.get("index_name"));

assertEquals(6, ((List)info.get("fields")).size());
assertEquals("global_idle", ((List)info.get("cursor_stats")).get(0));
assertEquals(0L, ((List)info.get("cursor_stats")).get(1));
}

@Test
Expand Down