-
Notifications
You must be signed in to change notification settings - Fork 66
docs: update install instructions to use uv in README #2467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update install instructions to use uv in README #2467
Conversation
WalkthroughThe README was updated to replace direct Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
35-36: Show the editable install as an explicit commandReaders usually copy-paste commands verbatim. Instead of a comment about “add -e”, provide a second line (or replace the current one) with the exact editable command, e.g.:
-pip install . # add -e if you're making local changes +pip install . # standard install +# for editable installs (recommended while developing): +pip install -e .This removes ambiguity and aligns with common Python-packaging docs.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
README.md (1)
Learnt from: EdDev
PR: #2291
File: ocp_resources/resource.py:126-126
Timestamp: 2025-01-28T07:25:19.573Z
Learning: The environment variable OPENSHIFT_PYTHON_WRAPPER_CLIENT_USE_PROXY must be set and not empty to override the use_proxy parameter in the get_client function.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: can-be-merged
- GitHub Check: conventional-title
- GitHub Check: can-be-merged
- GitHub Check: can-be-merged
- GitHub Check: can-be-merged
- GitHub Check: conventional-title
- GitHub Check: can-be-merged
- GitHub Check: conventional-title
- GitHub Check: tox
- GitHub Check: python-module-install
6b23f7e to
d7cc30a
Compare
176d6ae to
b2f51aa
Compare
b2f51aa to
61f8649
Compare
…DME.md Signed-off-by: Samuel Albershtein <[email protected]>
61f8649 to
b9e99c2
Compare
|
/verified |
This PR updates the README to reflect the correct installation using uv with
pyproject.tomlsetup.pydoesn't exist.Summary by CodeRabbit
Summary by CodeRabbit
uvtool.