Skip to content

Update wait_for_status_success() call to look at both type and status for status.conditions #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 27, 2025
Merged

Update wait_for_status_success() call to look at both type and status for status.conditions #2289

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
025dd62
status should return reason, when condition status is True
dbasunag Jan 22, 2025
521064e
based on review comments and offline conversation with dev team
dbasunag Jan 22, 2025
9aca3b6
remove unnecessary code
dbasunag Jan 22, 2025
600f8e7
undo retry
dbasunag Jan 22, 2025
6103075
addressed review comment
dbasunag Jan 23, 2025
5a2acf3
Merge remote-tracking branch 'origin' into nncp
dbasunag Jan 23, 2025
c1d6719
address review comment
dbasunag Jan 24, 2025
2332a0b
update based on reviews
dbasunag Jan 26, 2025
4f08515
Merge branch 'main' into nncp
dbasunag Jan 27, 2025
6b7862f
Merge branch 'main' into nncp
dbasunag Jan 27, 2025
6c4d2ce
Merge branch 'main' into nncp
dbasunag Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ocp_resources/node_network_configuration_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,10 @@ def _absent_interface(self):
@property
def status(self):
for condition in self.instance.status.conditions:
if condition["type"] == self.Conditions.Type.AVAILABLE:
if (
condition["type"] == self.Conditions.Type.AVAILABLE
and condition["status"] == self.Condition.Status.TRUE
):
return condition["reason"]

def wait_for_configuration_conditions_unknown_or_progressing(self, wait_timeout=30):
Expand Down