Skip to content

Fix click events behavior #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Fix click events behavior #1142

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ad111a
fix: click events behavior
gabrieljablonski Dec 20, 2023
532640a
docs: update source comments
gabrieljablonski Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/components/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,13 +477,20 @@ const Tooltip = ({
const enabledEvents: { event: string; listener: (event?: Event) => void }[] = []

const handleClickOpenTooltipAnchor = (event?: Event) => {
if (show) {
if (show && event?.target === activeAnchor) {
/**
* ignore clicking the anchor that was used to open the tooltip.
* this avoids conflict with the click close event.
*/
return
}
handleShowTooltip(event)
}
const handleClickCloseTooltipAnchor = () => {
if (!show) {
const handleClickCloseTooltipAnchor = (event?: Event) => {
if (!show || event?.target !== activeAnchor) {
/**
* same reasoning as above, opposite logic.
*/
return
}
handleHideTooltip()
Expand Down