Skip to content

Conversation

@gert-janvercauteren
Copy link
Contributor

Removing the dash from the package name makes Swift package manager behave. It nog longer replaces the dash with an underscore.

@mjarvis
Copy link
Member

mjarvis commented Oct 29, 2019

Thanks @jookes. Could you please update CHANGELOG.md? This would be considered a breaking change by SEMVER.

@gert-janvercauteren
Copy link
Contributor Author

I have bumped the library to 1.3.0, as the name is breaking, but no breaking API changes. Would you require a bump to 2.0.0?

@mjarvis
Copy link
Member

mjarvis commented Oct 29, 2019

For now , put it under an Upcoming header, rather than a specific version number -- we can decide on the version when a release is made.

Put the SPM change under upcoming release
@jaerod95
Copy link

Whatever happened to this? It seems to be stale. Can we get this merged in?

@mjarvis mjarvis merged commit 8519130 into ReSwift:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants