Introduce interval class for hit() methods #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollasch
commented
Oct 31, 2020
books/RayTracingInOneWeekend.html
Outdated
| // Find the nearest root that lies in the acceptable range. | ||
| auto root = (-half_b - sqrtd) / a; | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight | ||
| if (!t.contains(root)) { |
There was a problem hiding this comment.
Will fix this in subsequent commit.
hollasch
commented
Oct 31, 2020
| for (int a = 0; a < 3; a++) { | ||
| auto t0 = fmin((minimum[a] - r.origin()[a]) / r.direction()[a], | ||
| (maximum[a] - r.origin()[a]) / r.direction()[a]); | ||
| auto t1 = fmax((minimum[a] - r.origin()[a]) / r.direction()[a], | ||
| (maximum[a] - r.origin()[a]) / r.direction()[a]); | ||
| ray_tmin = fmax(t0, ray_tmin); | ||
| ray_tmax = fmin(t1, ray_tmax); | ||
| auto ray_tmin = fmax(t0, ray_t.min); |
There was a problem hiding this comment.
Future change using interval intersection.
|
CHANGELOG needs addition |
|
Oif. |
|
What am I looking at? this seems like a gargantuan omni-bus of a PR |
|
Yup. Basically, introduce the |
|
I quickly identified at least eight different cases where this would help, and I'd rather develop/PR them one-by-one than submit one gigantic hairball. |
|
Ref: #777 |
trevordblack
approved these changes
Nov 3, 2020
Comment on lines
+3
to
+10
| //============================================================================================== | ||
| // To the extent possible under law, the author(s) have dedicated all copyright and related and | ||
| // neighboring rights to this software to the public domain worldwide. This software is | ||
| // distributed without any warranty. | ||
| // | ||
| // You should have received a copy (see file COPYING.txt) of the CC0 Public Domain Dedication | ||
| // along with this software. If not, see <http://creativecommons.org/publicdomain/zero/1.0/>. | ||
| //============================================================================================== |
There was a problem hiding this comment.
New copyright template
There was a problem hiding this comment.
Thanks for the review. What about the copyright? It's the same as the others, except for the "Originally written" lines some have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of additional use cases for interval pending, but just tackling the
hitmethods for now.