Skip to content

Fix camera initialization with explicit vup vector #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2020
Merged

Fix camera initialization with explicit vup vector #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a06f8f7
Fix camera initialization with explicit vup vector
hollasch May 15, 2020
238fa31
Update changelog
hollasch May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Change Log -- Ray Tracing in One Weekend
# v3.1.1 (in progress)

### _In One Weekend_
- Fix: Camera initialization with explicit up vector (#537)
- Change: The C++ `<random>` version of `random_double()` no longer depends on `<functional>`
header.
- Change: Refactored `random_scene()`. More named intermediate values, sync'ed with source.
Expand Down
2 changes: 1 addition & 1 deletion books/RayTracingInOneWeekend.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2669,7 +2669,7 @@
This allows us to change the viewpoint:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
camera cam(point3(-2,2,1), point3(0,0,-1), vup, 90, aspect_ratio);
camera cam(point3(-2,2,1), point3(0,0,-1), vec3(0,1,0), 90, aspect_ratio);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[Listing [scene-free-view]: <kbd>[main.cc]</kbd> Scene with alternate viewpoint]

Expand Down