Update camera code #536
Merged
Update camera code #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the prior code, changes to camera variables would require associated changes to a number of other related variables, in ways that were not apparent. This change uses variables a more consistent manner, where changing any particular variable should yield consistent results in other values. In addition, this provides a more consistent series of iterative steps as the camera develops through the text. Resolves #527
dafhi
reviewed
May 16, 2020
trevordblack
approved these changes
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the prior code, changes to camera variables would require associated
changes to a number of other related variables, in ways that were not
apparent. This change uses variables a more consistent manner, where
changing any particular variable should yield consistent results in
other values.
In addition, this provides a more consistent series of iterative steps
as the camera develops through the text.
Resolves #527