More mnemonics #90
Open
More mnemonics #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83
These commits add additional support for the remaining BIP39 languages (traditional chinese, italian, and korean). Auto-detection of language from locale was already present, but modified slightly to compare based on a
new Locale(lang).getLanguage()instead of justlang, as recommended in the Android docs. Simplified vs. Traditional Chinese may still need some extra checks (such asgetCountry(), although I am not certain this is fool-proof), as it seemsgetLanguage()can still return "zh" for some traditional locales.In regards to selecting an English override for the 12-words, the app was already searching through the set of available languages and choosing any match, so this is not necessarily needed. Instead, perhaps the InputWordsActivity could display a message such as "Enter your 12 words in their original language", translated as appropriate.
Lastly, instrumentation tests were added (
androidTest/PaperKeyAndroidTests.java) to validate the paper key checks, even when the word language does not match the locale. Some more generalized locale tests are also in place, although these could be expanded for Chinese.