Fix build error on musl #791
Open
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On musl, this fails to build since basename(3) is undefined:
/tmp/src/clr-rocm-6.4.3/rocclr/os/os_posix.cpp:736:27: error: 'basename' was not declared in this scope; did you mean 'rename'?
736 | appName = std::string(basename(buff.get()));
| ^~~~~~~~
| rename
Add the missing import.
12 tasks
marifamd
pushed a commit
that referenced
this pull request
Aug 28, 2025
Author
|
Ref: #699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Builds fail on musl due to usage of internal types and missing imports.
Technical Details
Fixed build errors on musl. See individual commit messages for details.
Test Plan
Run builds.
Test Result
Builds work.
Submission Checklist
Closes: ROCm/clr#258