Fix compilation errors with musl libc #463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `error.h` is a GNU extension and is not provided by musl. Replaced with fprintf. 2. NULL is defined to `std::nullptr_t`, reinterpret_cast from `std::nullptr_t` to `void **` is not allowed. But static_cast is allowed.[1] [1] https://en.cppreference.com/w/cpp/language/reinterpret_cast#:~:text=Note%20that%20the%20null%20pointer,be%20used%20for%20this%20purpose. Signed-off-by: Sv. Lockal <[email protected]>
AngryLoki
added a commit
to AngryLoki/gentoo
that referenced
this pull request
May 22, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <[email protected]>
littlewu2508
pushed a commit
to littlewu2508/gentoo
that referenced
this pull request
May 23, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <[email protected]>
|
(accidentally closed wrong pull-request) |
AngryLoki
added a commit
to AngryLoki/gentoo
that referenced
this pull request
Jun 11, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <[email protected]>
negril
pushed a commit
to negril/gentoo
that referenced
this pull request
Jun 25, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <[email protected]> Signed-off-by: Paul Zander <[email protected]>
negril
pushed a commit
to negril/gentoo
that referenced
this pull request
Jun 25, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <[email protected]> Signed-off-by: Paul Zander <[email protected]>
negril
pushed a commit
to negril/gentoo
that referenced
this pull request
Jun 25, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jun 26, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <[email protected]> Signed-off-by: Sam James <[email protected]>
rahulc-gh
pushed a commit
that referenced
this pull request
Aug 7, 2025
rahulc-gh
pushed a commit
that referenced
this pull request
Aug 7, 2025
…#463) (#464) ## Associated JIRA ticket number/Github issue number [SWDEV-545245](https://ontrack-internal.amd.com/browse/SWDEV-545245) ## What type of PR is this? (check all applicable) - [ ] Refactor - [ ] Feature - [ ] Bug Fix - [ ] Optimization - [ ] Documentation Update - [ ] Continuous Integration ## What were the changes? Unit positive and negative test for hipDeviceGetTexture1DLinearMaxWidth ## Why are these changes needed? <!-- Please explain the motivation behind the change and why this solves the given problem. --> ## Updated CHANGELOG? <!-- Needed for Release updates for a ROCm release. --> - [ ] Yes - [ ] No, Does not apply to this PR. ## Added/Updated documentation? - [ ] Yes - [ ] No, Does not apply to this PR. ## Additional Checks - [ ] I have added tests relevant to the introduced functionality, and the unit tests are passing locally. - [ ] Any dependent changes have been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error.his a GNU extension and is not provided by musl. Replaced with fprintf.std::nullptr_t, reinterpret_cast fromstd::nullptr_ttovoid **is not allowed[1]. But static_cast is allowed.[1] reinterpret_cast conversion - cppreference.com