Skip to content

Conversation

@illsilin
Copy link
Collaborator

@illsilin illsilin commented Feb 2, 2023

Please feel free to add more contents as needed.

In the future, every time you make a major commit, you should add a line about it in the changelog.md file.

geyyer
geyyer previously approved these changes Feb 3, 2023
Copy link
Contributor

@geyyer geyyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get it started!

@aosewski
Copy link
Collaborator

aosewski commented Feb 6, 2023

@illsilin What do you think about adding PR# for each bullet in Changelog?

@illsilin
Copy link
Collaborator Author

illsilin commented Feb 8, 2023

I personally think adding the PR# or commit hash to the changelog would be useful. But the instruction was to create the changelog following the same format as other ROCM libraries, e.g. rocFFT:

https://github.com/ROCmSoftwarePlatform/rocFFT/blob/develop/CHANGELOG.md

I'll check with Jun or whoever is in charge of this what they think.

@illsilin
Copy link
Collaborator Author

illsilin commented Feb 8, 2023

OK, sounds like we can add the PR# or commit hash if we like.

Copy link
Contributor

@zjing14 zjing14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asroy asroy merged commit b63acce into develop Feb 8, 2023
@illsilin illsilin deleted the lwpck-589 branch March 1, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants