-
Notifications
You must be signed in to change notification settings - Fork 250
[CK_TILE] Improve F8F6F4 Scaled WarpGemm #3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors and improves the F8F6F4 scaled warp GEMM implementation by consolidating multiple type-specific implementations into a single generic template structure and enabling multiple access modes (single, double, quad) for fp8/bf8 operations.
Key changes:
- Consolidates multiple specialized
WarpGemmAttributeMfmaImpl_f32_16x16x128_*structs into a single genericWarpGemmAttributeMfmaImpl_f32_16x16x128_f8f6f4template - Adds new inner namespace
wrap_gemm_dispatcherwithinimplnamespace with enum constant aliases for cleaner code - Enables templated dispatcher pattern for scaled MFMA operations (fp8/bf8 combinations with 16x16x128 configuration) to support multiple access modes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| warp_gemm_dispatcher.hpp | Refactored dispatcher by introducing inner namespace, renaming template struct, and adding templated specializations for scaled f8f6f4 operations |
| warp_gemm_attribute_mfma_impl.hpp | Consolidated multiple type-specific implementations into single generic template with improved type handling via lambdas |
| warp_gemm.hpp | Updated type aliases to reference the new unified implementation structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
include/ck_tile/ops/gemm/warp/warp_gemm_attribute_mfma_impl.hpp
Outdated
Show resolved
Hide resolved
include/ck_tile/ops/gemm/warp/warp_gemm_attribute_mfma_impl.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* [CK_TILE] Improve F8F6F4 Scaled WarpGemm * Thanks, Copilot
Proposed changes
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed files