fix: skip apply journal during vnode diff #8143
Draft
+95
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Varixo
force-pushed
the
v2-skip-journal-during-diff
branch
from
2e40544 to
740101b
Compare
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Varixo
force-pushed
the
v2-skip-journal-during-diff
branch
3 times, most recently
from
623287d to
a21e92b
Compare
commit: |
wmertens
reviewed
Nov 10, 2025
| $blockedChores$: null, | ||
| $startTime$: undefined, | ||
| $endTime$: undefined, | ||
| $blocksJournalFlush$: shouldBlockJournalFlush, |
Member
There was a problem hiding this comment.
isn't it better to calculate from type this every time? Here we're adding a minimum of 8 bytes to each chore.
We could also make Chore a class and use a getter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.