add a warning box when connecting an anon vm to a non-anon gateway #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
+ Coverage 68.33% 68.89% +0.55%
==========================================
Files 17 17
Lines 3708 3838 +130
==========================================
+ Hits 2534 2644 +110
- Misses 1174 1194 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 17, 2025
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025040612-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests6 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable testsPerformance TestsPerformance degradation:14 performance degradations
Remaining performance tests:58 tests
|
This was referenced Mar 17, 2025
marmarek
reviewed
Mar 19, 2025
qubesmanager/settings.py
Outdated
Comment on lines
766
to
769
| "Anon AppVM must be connected to an anon gateway to " | ||
| "ensure your privacy and anonymity. By changing the NetVM " | ||
| "to a clear gateway, your IP address will be LEAKED on the " | ||
| "Internet. Continue at your own risk.") |
There was a problem hiding this comment.
@marmarta is the message okay?
There was a problem hiding this comment.
I don't love it. The all-caps LEAKED doesn't really fit the style we try to use. Also, we try to move away from VM and towards qube. Also I'm not sure if "clear gateway" is understandable (yes, I can figure this out, but error messages should not need figuring out); I don't have ideas for a short and understandable phrasing here.
Maybe something like:
"Anonymous qubes must be connected to an anonymous gateway to ensure privacy and anonymity. By changing the net qube to a ???? gateway, your IP address will be leaked to the Internet. Continue at your own risk"
This was referenced Mar 21, 2025
Merged
Enable GUI event buffering for new Whonix-Workstation qubes
QubesOS/qubes-core-admin-addon-whonix#20
Merged
Guiiix
force-pushed
the
anon_warning_main
branch
from
b39aea6 to
03a8461
Compare
|
Is it better? |
|
Much better! |
marmarta
approved these changes
Mar 31, 2025
This was referenced Mar 31, 2025
|
pylint complains about too long lines... |
Anon AppVM like anon-whonix needs an anon-gateway like sys-whonix to provide a correct level of anonymity and privacy. This commit adds a warning when a user try to connect a VM with the tag anon-vm to a Net Qube that does not have the tag anon-gateway
Guiiix
force-pushed
the
anon_warning_main
branch
from
03a8461 to
26e8131
Compare
sorry, fixed |
This was referenced Apr 7, 2025
marmarek
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: QubesOS/qubes-issues#8551
Anon AppVM like anon-whonix needs an anon-gateway like sys-whonix to provide a correct level of anonymity and privacy. This commit adds a warning when a user try to connect a VM with the tag anon-vm to a Net Qube that does not have the tag anon-gateway
For tests to pass, QubesOS/qubes-core-admin-client#343 must be merged.