-
-
Notifications
You must be signed in to change notification settings - Fork 71
Add the feature to prohibit starting a qube #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9ddab41 to
b04dc69
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
==========================================
+ Coverage 68.34% 68.39% +0.04%
==========================================
Files 17 17
Lines 3706 3727 +21
==========================================
+ Hits 2533 2549 +16
- Misses 1173 1178 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8d3cbab to
202a603
Compare
202a603 to
6fe2988
Compare
|
Improving unittests and adding individual unittest. Should make the Codecov green |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031004-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests32 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 8 fixed
Unstable testsPerformance TestsPerformance degradation:28 performance degradations
Remaining performance tests:44 tests
|
6fe2988 to
00dbb84
Compare
I'll click restart... |
f5ef993 to
fad45f3
Compare
fad45f3 to
9f34b17
Compare
9f34b17 to
542c81e
Compare
542c81e to
b1fd3a6
Compare
b1fd3a6 to
d7f9f5b
Compare
|
unit test fails |
b864707 to
0fea5d5
Compare
The unittest was correctly detecting that something was wrong. The logic in the Qube Manager was incomplete and only updated |
Qube Manager part of preventing qubes with `prohibit-start` from being started. Showing special status icon and disabling start and related buttons. Supplements: QubesOS/qubes-issues#9622
Qube Manager part of preventing qubes with
prohibit-startfrom being started. Showing special status icon and disabling start and related buttons.Supplements: QubesOS/qubes-issues#9622