Skip to content

Conversation

@ben-grande
Copy link
Contributor

@ben-grande ben-grande commented Oct 2, 2025

Shell parsers get confused with quotes, this happens with qubes-i3-xdg-autostart which tries to add more quotes:

+ sh -c '"systemctl' --user import-environment XDG_CURRENT_DESKTOP ... 'XDG_SESSION_TYPE;' systemctl --user start 'qubes-app-menu"'
--user: -c: line 1: unexpected EOF while looking for matching `"'

@ben-grande
Copy link
Contributor Author

Where can I view the logs of why code-signing failed? It opens the docs page when clicking "View details".

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.53%. Comparing base (a4c3ac3) to head (6c4826c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   79.53%   79.53%           
=======================================
  Files          23       23           
  Lines        2561     2561           
=======================================
  Hits         2037     2037           
  Misses        524      524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Shell parsers get confused with quotes, this happens with
qubes-i3-xdg-autostart which tries to add more quotes:

+ sh -c '"systemctl' --user import-environment XDG_CURRENT_DESKTOP ... 'XDG_SESSION_TYPE;' systemctl --user start 'qubes-app-menu"'
--user: -c: line 1: unexpected EOF while looking for matching `"'
@deeplow
Copy link

deeplow commented Oct 2, 2025

Where can I view the logs of why code-signing failed? It opens the docs page when clicking "View details".

I don't know about the logs, but it seems to fetch the key from GitHub among other sources. So uploading to GitHub at least should fix it. After that, your key will be available at https://github.com/ben-grande.gpg.

@ben-grande
Copy link
Contributor Author

@ben-grande
Copy link
Contributor Author

Where can I view the logs of why code-signing failed? It opens the docs page when clicking "View details".

I don't know about the logs, but it seems to fetch the key from GitHub among other sources. So uploading to GitHub at least should fix it. After that, your key will be available at https://github.com/ben-grande.gpg.

Thanks.
I avoided adding my key to github to not trick users to trust the green "Verified" mark, but I guess, as per Marek's response, either he merges it there or I add my key to my profile.

@marmarek
Copy link
Member

marmarek commented Oct 2, 2025

PipelineRetryFailed

@marmarek
Copy link
Member

While the change itself is okay,

this happens with qubes-i3-xdg-autostart which tries to add more quotes

...this is an issue in qubes-i4-xdg-autostart, it mishandles quotes - see spec at https://specifications.freedesktop.org/desktop-entry-spec/latest/exec-variables.html

@ben-grande
Copy link
Contributor Author

While the change itself is okay,

this happens with qubes-i3-xdg-autostart which tries to add more quotes

...this is an issue in qubes-i4-xdg-autostart, it mishandles quotes - see spec at https://specifications.freedesktop.org/desktop-entry-spec/latest/exec-variables.html

eval was the solution I found. As we need to trust the file already, it doesn't seem problematic to use eval.

QubesOS/qubes-desktop-linux-i3-settings-qubes@8008f34

@ben-grande ben-grande closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants