Skip to content

Stop eating spaces when a non-search widget is selected #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Stop eating spaces when a non-search widget is selected #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions qubes_menu/appmenu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,13 +252,18 @@
"""
Keypress handler, to allow closing the menu with an ESC key and to fix
some issues with space (as we have search by default, we should not
react to space with launching an app).
react to space with launching an app, but instead put the space
into the search bar).

Check warning on line 256 in qubes_menu/appmenu.py

View check run for this annotation

Codecov / codecov/patch

qubes_menu/appmenu.py#L255-L256 

Added lines #L255 - L256 were not covered by tests
"""
if event.keyval == Gdk.KEY_Escape:
self.hide_menu()
if event.keyval == Gdk.KEY_space:
if not isinstance(self.get_active_window().get_focus(),
Gtk.SearchEntry):
current_widget = self.get_active_window().get_focus()
if isinstance(current_widget,
Gtk.SearchEntry):
p = current_widget.get_position()

Check warning on line 264 in qubes_menu/appmenu.py

View check run for this annotation

Codecov / codecov/patch

qubes_menu/appmenu.py#L261-L264 

Added lines #L261 - L264 were not covered by tests
current_widget.insert_text(" ", p)
current_widget.set_position(p + 1)
return True
Copy link
Contributor

@coyotebush coyotebush Jul 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose current_widget is the same as the widget receiving the event? If so, this return value (whether to stop propagation) seems backwards: the search widget should continue handling the event (by inserting a space itself), while the menu items should stop handling the event. The code before this change makes more sense to me.

return False

Expand Down