Skip to content

Add preload memory threshold spin button #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

Add preload memory threshold spin button #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 97 additions & 26 deletions qubes_config/global_config.glade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@
<property name="can-focus">False</property>
<property name="vscroll-policy">natural</property>
<child>
<!-- n-columns=2 n-rows=26 -->
<!-- n-columns=2 n-rows=27 -->
<object class="GtkGrid" id="basics_contents">
<property name="visible">True</property>
<property name="can-focus">False</property>
Expand Down Expand Up @@ -1069,7 +1069,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">10</property>
<property name="top-attach">11</property>
<property name="width">2</property>
</packing>
</child>
Expand All @@ -1085,7 +1085,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">13</property>
<property name="top-attach">14</property>
</packing>
</child>
<child>
Expand All @@ -1101,7 +1101,7 @@
</object>
<packing>
<property name="left-attach">1</property>
<property name="top-attach">13</property>
<property name="top-attach">14</property>
</packing>
</child>
<child>
Expand All @@ -1114,7 +1114,7 @@
</object>
<packing>
<property name="left-attach">1</property>
<property name="top-attach">14</property>
<property name="top-attach">15</property>
</packing>
</child>
<child>
Expand All @@ -1127,7 +1127,7 @@
</object>
<packing>
<property name="left-attach">1</property>
<property name="top-attach">15</property>
<property name="top-attach">16</property>
</packing>
</child>
<child>
Expand Down Expand Up @@ -1238,7 +1238,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">17</property>
<property name="top-attach">18</property>
<property name="width">2</property>
</packing>
</child>
Expand All @@ -1255,7 +1255,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">18</property>
<property name="top-attach">19</property>
<property name="width">2</property>
</packing>
</child>
Expand All @@ -1271,7 +1271,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">22</property>
<property name="top-attach">23</property>
<property name="width">2</property>
</packing>
</child>
Expand All @@ -1283,7 +1283,7 @@
</object>
<packing>
<property name="left-attach">1</property>
<property name="top-attach">24</property>
<property name="top-attach">25</property>
</packing>
</child>
<child>
Expand All @@ -1295,7 +1295,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">25</property>
<property name="top-attach">26</property>
<property name="width">2</property>
</packing>
</child>
Expand All @@ -1312,7 +1312,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">23</property>
<property name="top-attach">24</property>
<property name="width">2</property>
</packing>
</child>
Expand Down Expand Up @@ -1462,7 +1462,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">11</property>
<property name="top-attach">12</property>
<property name="width">2</property>
</packing>
</child>
Expand Down Expand Up @@ -1509,7 +1509,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">12</property>
<property name="top-attach">13</property>
<property name="width">2</property>
</packing>
</child>
Expand Down Expand Up @@ -1554,7 +1554,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">14</property>
<property name="top-attach">15</property>
</packing>
</child>
<child>
Expand All @@ -1578,7 +1578,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">9</property>
<property name="top-attach">10</property>
</packing>
</child>
<child>
Expand All @@ -1590,7 +1590,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">16</property>
<property name="top-attach">17</property>
</packing>
</child>
<child>
Expand All @@ -1602,7 +1602,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">21</property>
<property name="top-attach">22</property>
</packing>
</child>
<child>
Expand Down Expand Up @@ -1633,7 +1633,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">15</property>
<property name="top-attach">16</property>
</packing>
</child>
<child>
Expand All @@ -1648,7 +1648,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">24</property>
<property name="top-attach">25</property>
</packing>
</child>
<child>
Expand All @@ -1663,7 +1663,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">19</property>
<property name="top-attach">20</property>
</packing>
</child>
<child>
Expand All @@ -1678,7 +1678,7 @@
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">20</property>
<property name="top-attach">21</property>
</packing>
</child>
<child>
Expand Down Expand Up @@ -1718,7 +1718,7 @@
</object>
<packing>
<property name="left-attach">1</property>
<property name="top-attach">19</property>
<property name="top-attach">20</property>
</packing>
</child>
<child>
Expand Down Expand Up @@ -1758,7 +1758,7 @@
</object>
<packing>
<property name="left-attach">1</property>
<property name="top-attach">20</property>
<property name="top-attach">21</property>
</packing>
</child>
<child>
Expand Down Expand Up @@ -1858,7 +1858,7 @@
<packing>
<property name="expand">False</property>
<property name="fill">True</property>
<property name="position">2</property>
<property name="position">0</property>
</packing>
</child>
<child>
Expand All @@ -1876,7 +1876,7 @@
<packing>
<property name="expand">False</property>
<property name="fill">True</property>
<property name="position">3</property>
<property name="position">1</property>
</packing>
</child>
</object>
Expand All @@ -1885,6 +1885,77 @@
<property name="top-attach">8</property>
</packing>
</child>
<child>
<object class="GtkBox">
<property name="visible">True</property>
<property name="can-focus">False</property>
<child>
<object class="GtkSpinButton" id="basics_preload_dispvm_threshold">
Copy link
Member

@marmarta marmarta Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs margin-start? Because in the finished window it's a couple of pixels to the left of the other controls in its column.

Copy link
Author

@ben-grande ben-grande Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="valign">center</property>
<property name="margin-start">5</property>
<property name="max-width-chars">6</property>
</object>
<packing>
<property name="expand">False</property>
<property name="fill">True</property>
<property name="position">0</property>
</packing>
</child>
<child>
<object class="GtkLabel">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="halign">start</property>
<property name="margin-start">5</property>
<property name="margin-end">5</property>
<property name="hexpand">True</property>
<property name="label" translatable="yes">MiB</property>
<style>
<class name="main_text"/>
</style>
</object>
<packing>
<property name="expand">False</property>
<property name="fill">True</property>
<property name="position">1</property>
</packing>
</child>
</object>
<packing>
<property name="left-attach">1</property>
<property name="top-attach">9</property>
</packing>
</child>
<child>
<object class="GtkBox">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="orientation">vertical</property>
<child>
<object class="GtkLabel">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="label" translatable="yes">The amount of free system memory that will never be used for preloading disposables. Ensures preloaded disposables do not consume all available memory.</property>
<property name="wrap">True</property>
<property name="xalign">0</property>
<style>
<class name="explanation"/>
</style>
</object>
<packing>
<property name="expand">False</property>
<property name="fill">True</property>
<property name="position">0</property>
</packing>
</child>
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">9</property>
</packing>
</child>
<child>
<placeholder/>
</child>
Expand Down
Loading