Skip to content

Fix setting VM label in domains widgets in some circumstances #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Fix setting VM label in domains widgets in some circumstances #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions qui/tray/domains.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,19 +502,14 @@ def __init__(self, vm, app, icon_cache, state=None):
self.decorator = qui.decorators.DomainDecorator(vm)

# Main horizontal box
hbox = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL)
self.hbox = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL)

# Icon box with fixed width
iconbox = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL)
iconbox.set_size_request(16, 0)
icon = self.decorator.icon()
if icon:
iconbox.pack_start(icon, False, True, 0)
else:
placeholder = Gtk.Label()
iconbox.pack_start(placeholder, False, True, 0)
self.iconbox = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL)
self.iconbox.set_size_request(16, 0)
self.set_label_icon()

hbox.pack_start(iconbox, False, True, 6)
self.hbox.pack_start(self.iconbox, False, True, 6)

# Name box
namebox = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL)
Expand All @@ -523,7 +518,7 @@ def __init__(self, vm, app, icon_cache, state=None):
self.spinner = Gtk.Spinner()
namebox.pack_start(self.spinner, False, True, 0)

hbox.pack_start(namebox, True, True, 0)
self.hbox.pack_start(namebox, True, True, 0)

# Memory and CPU box
mem_cpu_box = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL)
Expand All @@ -532,10 +527,10 @@ def __init__(self, vm, app, icon_cache, state=None):
self.cpu = self.decorator.cpu()
mem_cpu_box.pack_start(self.cpu, False, True, 0)

hbox.pack_start(mem_cpu_box, False, True, 0)
self.hbox.pack_start(mem_cpu_box, False, True, 0)

# Add hbox to the menu item
self.add(hbox)
self.add(self.hbox)

if self.vm is None: # if header
self.set_reserve_indicator(True) # align with submenu triangles
Expand Down Expand Up @@ -618,6 +613,17 @@ def update_stats(self, memory_kb, cpu_usage):
self.memory.update_state(int(memory_kb))
self.cpu.update_state(int(cpu_usage))

def set_label_icon(self):
for child in self.iconbox.get_children():
self.iconbox.remove(child)
icon = self.decorator.icon()
if icon:
self.iconbox.pack_start(icon, False, True, 0)
icon.show()
else:
placeholder = Gtk.Label()
self.iconbox.pack_start(placeholder, False, True, 0)


class DomainTray(Gtk.Application):
"""A tray icon application listing all but halted domains. ”"""
Expand Down