Skip to content

updater: make UpdateListIter a proper iterator #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2025
Merged

updater: make UpdateListIter a proper iterator #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions qui/updater/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,9 @@
self.list_store_wrapped = list_store_wrapped
self._id = -1

def __iter__(self) -> "UpdateListIter":
Copy link

@merwok merwok Jun 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW you can use typing.Self here to make intent clearer and work in (eventual) subclasses

return self

Check warning on line 278 in qui/updater/utils.py

View check run for this annotation

Codecov / codecov/patch

qui/updater/utils.py#L278 

Added line #L278 was not covered by tests

def __next__(self) -> RowWrapper:
self._id += 1
if 0 <= self._id < len(self.list_store_wrapped):
Expand Down