Skip to content

Conversation

@marmarta
Copy link
Member

@marmarta marmarta commented May 6, 2024

@marmarta marmarta force-pushed the remove_pkg_resources branch from fd5a1b2 to 173fd24 Compare May 7, 2024 11:38
@codecov
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.61%. Comparing base (87a28b3) to head (173fd24).
Report is 3 commits behind head on main.

Files Patch % Lines
qubesappmenus/receive.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   62.53%   62.61%   +0.07%     
==========================================
  Files           2        2              
  Lines         670      674       +4     
==========================================
+ Hits          419      422       +3     
- Misses        251      252       +1     
Flag Coverage Δ
unittests 62.61% <75.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marmarek marmarek merged commit 1dfe2b7 into QubesOS:main May 17, 2024
@marmarek
Copy link
Member

May 17 09:46:48 sys-gui qubes-app-menu[2823]: Traceback (most recent call last):
May 17 09:46:48 sys-gui qubes-app-menu[2823]:   File "/usr/bin/qvm-sync-appmenus", line 33, in <module>
May 17 09:46:48 sys-gui qubes-app-menu[2823]:     sys.exit(load_entry_point('qubesdesktop==4.2.8', 'console_scripts', 'qvm-sync-appmenus')())
May 17 09:46:48 sys-gui qubes-app-menu[2823]:              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
May 17 09:46:48 sys-gui qubes-app-menu[2823]:   File "/usr/lib/python3.11/site-packages/qubesappmenus/receive.py", line 411, in main
May 17 09:46:48 sys-gui qubes-app-menu[2823]:     process_appmenus_templates(appmenusext, vm, new_appmenus)
May 17 09:46:48 sys-gui qubes-app-menu[2823]:   File "/usr/lib/python3.11/site-packages/qubesappmenus/receive.py", line 308, in process_appmenus_templates
May 17 09:46:48 sys-gui qubes-app-menu[2823]:     template_data = importlib.resources.files(
May 17 09:46:48 sys-gui qubes-app-menu[2823]:                     ^^^^^^^^^^^^^^^^^^^^^^^^^^
May 17 09:46:48 sys-gui qubes-app-menu[2823]:   File "/usr/lib64/python3.11/importlib/resources/_common.py", line 22, in files
May 17 09:46:48 sys-gui qubes-app-menu[2823]:     return from_package(get_package(package))
May 17 09:46:48 sys-gui qubes-app-menu[2823]:                         ^^^^^^^^^^^^^^^^^^^^
May 17 09:46:48 sys-gui qubes-app-menu[2823]:   File "/usr/lib64/python3.11/importlib/resources/_common.py", line 55, in get_package
May 17 09:46:48 sys-gui qubes-app-menu[2823]:     raise TypeError(f'{package!r} is not a package')
May 17 09:46:48 sys-gui qubes-app-menu[2823]: TypeError: 'qubesappmenus.receive' is not a package

I'll revert this commit for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants