Skip to content

Conversation

@jamke
Copy link

@jamke jamke commented Oct 27, 2025

Remove --without-progress option from qvm-copy/move-to-vm man files, because these commands do not supported this option. I checked their code to verify it.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.10%. Comparing base (06dc32e) to head (563fc3d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   71.10%   71.10%           
=======================================
  Files           3        3           
  Lines         481      481           
=======================================
  Hits          342      342           
  Misses        139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marmarek
Copy link
Member

What do you mean not supported? It is, and works as expected:

[user@disp8260 ~]$ qvm-copy test.txt 
sent 1/1 KB
[user@disp8260 ~]$ qvm-copy --without-progress test.txt 
[user@disp8260 ~]$ 

@jamke
Copy link
Author

jamke commented Oct 29, 2025

What do you mean not supported?

qvm-copy supports, but qvm-copy-to-vm does not:

$ qvm-copy-to-vm --without-progress qube file.txt

stat qube
usage: qvm-run [--verbose] [--quiet] [--help] [--user USER] [--autostart]
               [--no-autostart] [--pass-io] [--localcmd COMMAND] [--gui]
               [--no-gui] [--colour-output COLOUR] [--colour-stderr COLOUR]
               [--no-colour-output] [--no-colour-stderr]
               [--filter-escape-chars] [--no-filter-escape-chars] [--service]
               [--no-shell] [--dispvm [BASE_APPVM] | --all]
               [--exclude EXCLUDE]
               [VMNAME] COMMAND ...
qvm-run: error: no such domain: '--without-progress'

@jamke
Copy link
Author

jamke commented Oct 29, 2025

I think, maybe that whole man qvm-copy should mention qvm-copy-to-vm at all anymore, as it is not supported to be called from qubes nowadays.
And another problem is that currently dom0 lacks man qvm-copy-to-vm.

@marmarek
Copy link
Member

qvm-copy supports, but qvm-copy-to-vm does not:

It does:

[user@disp8260 ~]$ qvm-copy-to-vm --without-progress disp4953 test.txt 
[user@disp8260 ~]$ 

I think you are talking about dom0's version of the tool. This repo is only about VM's variant and it supports the option.

@jamke
Copy link
Author

jamke commented Oct 29, 2025

I see, you are right. It's confusing that the same command works differently, but I got it.
I thought that docs about dom0's tool qvm-copy-to-vm were left in vm's man by mistake.
OK. I am closing this PR then.

@jamke jamke closed this Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants