-
-
Notifications
You must be signed in to change notification settings - Fork 125
Start qubes-bind-dirs.service before systemd-tmpfiles-setup.service #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tmpfiles.d may contain configuration to "fix" the permissions on some directories (like /var/lib/sdwdate on Whonix-Gateway qubes) in the event an app qube's template is changed and the UIDs/GIDs for some users in the original template do not match the UIDs/GIDs for the same users in the new template. This requires that bind mounts from /rw are set up before systemd-tmpfiles runs, so ensure that the units run in that order.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
- Coverage 71.10% 70.68% -0.42%
==========================================
Files 3 3
Lines 481 481
==========================================
- Hits 342 340 -2
- Misses 139 141 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't understand how it's possible that the Codecov coverage reduction can be related to this PR, unless the test suite depends on the startup timing of |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025102408-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests19 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 80 fixed
Unstable testsPerformance TestsPerformance degradation:17 performance degradations
Remaining performance tests:162 tests
|
tmpfiles.d may contain configuration to "fix" the permissions on some directories (like /var/lib/sdwdate on Whonix-Gateway qubes) in the event an app qube's template is changed and the UIDs/GIDs for some users in the original template do not match the UIDs/GIDs for the same users in the new template. This requires that bind mounts from /rw are set up before systemd-tmpfiles runs, so ensure that the units run in that order.