Fail early on missing service for preloaded disposables #711
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
- Coverage 70.56% 70.47% -0.09%
==========================================
Files 61 61
Lines 13604 13580 -24
==========================================
- Hits 9599 9570 -29
- Misses 4005 4010 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ben-grande
force-pushed
the
preload-global-ignore
branch
2 times, most recently
from
1b7fd4b to
5086775
Compare
ben-grande
changed the title
When switching the default-dispvm, there is no supported-rpc validation. Without this validation, it tries to preload and fails on startup validation. Raise exception early. It can happen also a packages in the template has been downgraded. For: QubesOS/qubes-issues#1512
ben-grande
force-pushed
the
preload-global-ignore
branch
from
5086775 to
4fb5be9
Compare
|
Resolved merge conflict. |
|
Please openqa. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025082411-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 72 fixed
Unstable testsPerformance TestsPerformance degradation:19 performance degradations
Remaining performance tests:155 tests
|
3 participants
Occurs when the global max preload feature, set on dom0, with the default-dispvm being an unsupported template, which can happen on old ISOs, old templates, downgraded templates or packages. When setting the dom0 feature or when switching the default-dispvm, there is no supported-rpc validation. Handle gracefully in case the qube is the default-dispvm and the global max feature is set.
Without this validation, it tries to preload and fails on startup check of the same supported-rpc, but this time, running it as a service.
For: QubesOS/qubes-issues#1512
Untested.
Without it, doesn't break anything, but a minor annoyance of failing the
qubes-preload-dispvm.serviceandqubesdlogs and the preloads trying to start to just fail. This has more chance of happening with the global preload feature as it doesn't check if the default-dispvm supports the necessary RPC service.