Skip to content

Make qubesd connected directly as an socket qrexec service #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2020
Merged

Make qubesd connected directly as an socket qrexec service #339

merged 3 commits into from
May 24, 2020

Conversation

@marmarek
Copy link
Member

Remove intermediate qubesd-query-fast proxy process. This requires changing
socket protocol to match what qrexec is sending in the header.

Fixes QubesOS/qubes-issues#3293

@marmarek marmarek mentioned this pull request Apr 20, 2020
Merged
@codecov
Copy link

codecov bot commented Apr 20, 2020 •
edited
Loading

Codecov Report

Merging #339 into master will increase coverage by 0.24%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   63.70%   63.95%   +0.24%     
==========================================
  Files          50       49       -1     
  Lines        9041     9044       +3     
==========================================
+ Hits         5760     5784      +24     
+ Misses       3281     3260      -21
Flag Coverage Δ
#unittests 63.95% <70.00%> (+0.24%) ⬆️
Impacted Files Coverage Δ
qubes/tools/qubesd_query.py 0.00% <0.00%> (ø)
qubes/api/__init__.py 75.44% <77.77%> (-0.02%) ⬇️
qubes/ext/core_features.py 97.14% <0.00%> (-2.86%) ⬇️
qubes/ext/qubesmanager.py
qubes/vm/qubesvm.py 52.23% <0.00%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d19496...158e22c. Read the comment docs.

@qubesos-bot
Copy link

qubesos-bot commented Apr 20, 2020 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/8317#dependencies

Failed tests

New failures

Compared to: https://openqa.qubes-os.org/tests/6362#dependencies

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/6362#dependencies

marmarek added 2 commits May 11, 2020 01:13
@marmarek
Make qubesd connected directly as an socket qrexec service
48ae89f 
Remove intermediate qubesd-query-fast proxy process.
This requires changing socket protocol to match what qrexec is sending
in the header.

Fixes QubesOS/qubes-issues#3293
@marmarek
Remove qubesd-query-fast
61143a9 
Since qubesd is connected directly as a socket-based qrexec service, the
qubesd-query-fast tool isn't needed anymore.
@marmarek
rpm: update dependency on qrexec
158e22c 
Policy engine (cli/daemon) accesses qubesd through a socket - must match
the protocol change.
@marmarek marmarek merged commit aebb159 into QubesOS:master May 24, 2020
@marmarek marmarek deleted the qubesd-socket branch November 8, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

openqa-pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Qubes 4 Admin API is way too inefficient

2 participants

@marmarek @qubesos-bot