Ignore preload as a dependency #390
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2025
|
PipelineRetryFailed |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 76.17% 76.15% -0.02%
==========================================
Files 53 53
Lines 9250 9251 +1
==========================================
- Hits 7046 7045 -1
- Misses 2204 2206 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There doesn't seem to be a sane setup that would set a preloaded disposable as a property of another qube or a system property. The core already ignores preloaded disposables in certain cases, do the same on the client to not have derived applications such as Qube Manager having to deal with it. Fixes: QubesOS/qubes-issues#10227 For: QubesOS/qubes-issues#1512
ben-grande
force-pushed
the
preload-template-switch
branch
from
5e76612 to
7ba9e48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be a sane setup that would set a preloaded disposable as a property of another qube or a system property. The core already ignores preloaded disposables in certain cases, do the same on the client to not have derived applications such as Qube Manager having to deal with it.
Fixes: QubesOS/qubes-issues#10227
For: QubesOS/qubes-issues#1512