Skip to content

Conversation

@ben-grande
Copy link
Contributor

The default-dvm is the global and local default_dispvm, this means that trying to remove the qube requires changing a lot of references.

Fixes: QubesOS/qubes-issues#10227
For: QubesOS/qubes-issues#1512

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.16%. Comparing base (cc9c5f5) to head (5271bf9).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
qubesadmin/tools/qvm_remove.py 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   76.16%   76.16%   -0.01%     
==========================================
  Files          53       53              
  Lines        9235     9247      +12     
==========================================
+ Hits         7034     7043       +9     
- Misses       2201     2204       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-grande ben-grande changed the title Add less import disposable template and disposable Add less important disposable template and disposable Oct 6, 2025
The default-dvm is the global and local default_dispvm, this means that
trying to remove the qube requires changing a lot of references.

Fixes: QubesOS/qubes-issues#10227
For: QubesOS/qubes-issues#1512
@ben-grande ben-grande force-pushed the preload-template-switch branch from c6d6462 to 29ca10f Compare October 6, 2025 12:51
@marmarta
Copy link
Member

marmarta commented Oct 8, 2025

the changes to mocks look fine, I wonder how will they influence other tests (in particular, I remember some terrifying tests in the updater that had some magic values related to number of qubes). But it should be good....

@ben-grande
Copy link
Contributor Author

ben-grande commented Oct 8, 2025

(in particular, I remember some terrifying tests in the updater that had some magic values related to number of qubes)

Oh, I remember it affecting some test in another repo.... I don't remember which one though. I changed from 13 qubes to 18 qubes or something similar to that.

@marmarek
Copy link
Member

marmarek commented Oct 8, 2025

Oh, I remember it affecting some test in another repo.... I don't remember which one though. I changed from 13 qubes to 18 qubes or something similar to that.

Somewhere here: QubesOS/qubes-desktop-linux-manager@c40d8ca

@ben-grande
Copy link
Contributor Author

Oh, I remember it affecting some test in another repo.... I don't remember which one though. I changed from 13 qubes to 18 qubes or something similar to that.

Somewhere here: QubesOS/qubes-desktop-linux-manager@c40d8ca

Oh, so that is why I didn't find while searching PRs for author:ben-grande :). Yes, that's it.

ben-grande added a commit to ben-grande/qubes-desktop-linux-manager that referenced this pull request Oct 8, 2025
@marmarek marmarek merged commit 8b62cd7 into QubesOS:main Oct 11, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't change property (referencing a qube) or state of qube when there are preloaded disposables in chain

3 participants