-
-
Notifications
You must be signed in to change notification settings - Fork 80
Add less important disposable template and disposable #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 76.16% 76.16% -0.01%
==========================================
Files 53 53
Lines 9235 9247 +12
==========================================
+ Hits 7034 7043 +9
- Misses 2201 2204 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The default-dvm is the global and local default_dispvm, this means that trying to remove the qube requires changing a lot of references. Fixes: QubesOS/qubes-issues#10227 For: QubesOS/qubes-issues#1512
Unless it is a global property. Fixes: QubesOS/qubes-issues#10227 For: QubesOS/qubes-issues#1512
c6d6462 to
29ca10f
Compare
|
the changes to mocks look fine, I wonder how will they influence other tests (in particular, I remember some terrifying tests in the updater that had some magic values related to number of qubes). But it should be good.... |
Oh, I remember it affecting some test in another repo.... I don't remember which one though. I changed from 13 qubes to 18 qubes or something similar to that. |
Somewhere here: QubesOS/qubes-desktop-linux-manager@c40d8ca |
Oh, so that is why I didn't find while searching PRs for |
The default-dvm is the global and local default_dispvm, this means that trying to remove the qube requires changing a lot of references.
Fixes: QubesOS/qubes-issues#10227
For: QubesOS/qubes-issues#1512