-
-
Notifications
You must be signed in to change notification settings - Fork 6
[inventory_dynamics] Code updates to inventory lecture #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for incomparable-parfait-2417f8 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The build is failing as it requires @jstac I have just added this into this PR. |
|
Thanks @mmcky . Is the numba warning after the imports caused by QE? We are using tic and toc. One quick work-around would be Should we suppress output after the pip install? |
lectures/inventory_dynamics.md
Outdated
| In addition to what's included in base Anaconda, we need to install the following packages | ||
|
|
||
| ```{code-cell} ipython3 | ||
| !pip install quantecon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| !pip install quantecon | |
| :tags: [hide-output] | |
| !pip install quantecon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jstac good call. I can take a look tomorrow at the numba warning 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mmcky :-)
I guess that's something we'll need to get to the bottom of as well 😬 |
@jstac we had fixed this issue prior. Might be just |
|
Thanks @HumphreyYang ! This is looking good. Green light from me. |
|
Many thanks @jstac for confirming! |
Switches from namedtuple to class(NamedTuple) for nicer, cleaner syntax.
Adds typing.
Simplifies the fori_loop discussion by removing the option of generating all shocks at once (which doesn't help much and requires more memory).
The coding style changes can be used as a model for updates to other lectures.