Skip to content

Conversation

stone9k
Copy link

@stone9k stone9k commented Sep 23, 2025

Description

bankAuth was not set when setting job with SetPlayerPrimaryJob -> toPlayerJob

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@Frowmza
Copy link
Contributor

Frowmza commented Sep 24, 2025

imo, static data shouldn't be in player data at all, bankAuth, isboss, payment, label. We could always access them thru core shared config/export by key which is player job name, so I think adding this is useless.

@stone9k
Copy link
Author

stone9k commented Sep 24, 2025

imo, static data shouldn't be in player data at all, bankAuth, isboss, payment, label. We could always access them thru core shared config/export by key which is player job name, so I think adding this is useless.

This is clearly a bug: the values are set correctly on login etc, but in this specific case bankAuth isn’t being applied.
Removing it as you suggest would break compatibility with existing resources that already rely on these fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants