-
Notifications
You must be signed in to change notification settings - Fork 557
Finish Pyomo.DoE GreyBox (ME-opt Hessian) #3740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djlaky I'm a little surprised at how minimal the changes were in test_greybox
. The coverage hasn't been reported yet but could you explain why you didn't need to add a new test for this?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3740 +/- ##
==========================================
+ Coverage 89.31% 89.33% +0.02%
==========================================
Files 896 896
Lines 103687 103752 +65
==========================================
+ Hits 92609 92688 +79
+ Misses 11078 11064 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixed typo in comment Co-authored-by: Bethany Nicholson <[email protected]>
It looks like my one additional test didn’t make it in a commit, I will add this shortly. It will naturally all be covered because we call the jacobian and hessian methods at each solve, but I do have a check hessian for the condition number. My next commit(s) will include this. I must have not pushed them with the PR. |
Also, while checking over this PR to make sure it made sense, I found a small bug in the Hessian computation. Please hold off on this one until I add more commits. Apologies @blnicho. |
Fixes # .
Added code to compute the Hessian in the condition number number case (ME-opt) instead of using
pass
. Also, update condition number objective to be log-scale to avoid numerical issues.Summary/Motivation:
Numerical issues caused a delay for adding this. We figured out the numerical issues and this is good to go from the math side.
Changes proposed in this PR:
condition number
option for Pyomo.DoE using GreyBox objective use the log of the condition numbercondition number
option (instead ofpass
being used)Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: