MAINT: update handling of license files to use PEP 639 #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Now that the licensing metadata won't be lost at the time of upload thanks to the release of https://github.com/pypa/gh-action-pypi-publish/releases/tag/v1.12.4 and Twine 6.1, this PR should be ready to go. Using the action might also make sense now, even if we don't switch to trusted publishing right away (but we should, at some point). Gentle ping, @rgommers! |
Member
Author
|
This still needs a |
Collaborator
|
Ah, right – I missed that. I shall remove it from the 1.9.0 milestone, then; unless we want it to be included. |
…expression Treat license files for vendored code correctly by including the full text of NumPy and SciPy license files, as required by the BSD licenses of those projects.
Also add PyPI classifier for 3.14
Member
Author
|
I'll look at getting a 1.9.0 release out this week with Python 3.14 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because it requires a future version ofmeson-python(xref mesonbuild/meson-python#681).Changes:
ANDfor MIT and BSD-3 is a little annoying (MIT-only is cleaner) but it is the correct thing to do, given that we have a minor amount of BSD-3 code taken over from NumPy/SciPy which wasn't written by me and hence would be annoying to relicense under the PyWavelets license.pyproject.tomlfor Python 3.14 while we're at it.