Skip to content

Conversation

@grlee77
Copy link
Contributor

@grlee77 grlee77 commented Nov 29, 2018

This tweaks the tests comparing the CWT coefficients to ones from Matlab to make sure they are sensitive to the phase.

In looking into #439, I found that the current tests were passing whether or not I conjugated the wavelet coefficients. With the change in this PR, the tests pass with the current cwt implementation, but fail if I change the cwt to use the conjugate the mother wavelet as suggested in #439.

@codecov-io
Copy link

Codecov Report

Merging #440 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files          23       23           
  Lines        3941     3941           
  Branches      458      458           
=======================================
  Hits         3184     3184           
  Misses        681      681           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fdf5d1...24c4763. Read the comment docs.

@grlee77
Copy link
Contributor Author

grlee77 commented Dec 14, 2018

This change was discussed in #439. The CWT tests can then be updated in #440 to reflect the new conjugation of the coefficients discussed there.

@grlee77 grlee77 merged commit 981b700 into PyWavelets:master Dec 14, 2018
@grlee77 grlee77 deleted the cwt_test_phase branch November 13, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants