Implement DB Associations API and a little refactoring. #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tazend
added a commit
that referenced
this pull request
Jul 13, 2023
- kinda revert the change from #304 where all collections inherit from `list` - there is now a new base class `MultiClusterMap`, which acts as a dict but is capable of holding data from multiple clusters (for example when querying database jobs from multiple clusters in pyslurm.db.Jobs) - improve docs
tazend
added a commit
that referenced
this pull request
Jul 19, 2023
- All collections inherit from `list` instead of `dict` now (this change is mostly motivated by multi-cluster support that will probably be added in the future) - Added work-in-progress API for database `Associations` - renamed `JobSearchFilter` to `JobFilter`
tazend
added a commit
that referenced
this pull request
Jul 19, 2023
- kinda revert the change from #304 where all collections inherit from `list` - there is now a new base class `MultiClusterMap`, which acts as a dict but is capable of holding data from multiple clusters (for example when querying database jobs from multiple clusters in pyslurm.db.Jobs) - improve docs
tazend
added a commit
that referenced
this pull request
Jul 19, 2023
- All collections inherit from `list` instead of `dict` now (this change is mostly motivated by multi-cluster support that will probably be added in the future) - Added work-in-progress API for database `Associations` - renamed `JobSearchFilter` to `JobFilter`
tazend
added a commit
that referenced
this pull request
Jul 19, 2023
- kinda revert the change from #304 where all collections inherit from `list` - there is now a new base class `MultiClusterMap`, which acts as a dict but is capable of holding data from multiple clusters (for example when querying database jobs from multiple clusters in pyslurm.db.Jobs) - improve docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listinstead ofdictnow (this change is mostly motivated by multi-cluster support that will probably be added in the future)AssociationsJobSearchFiltertoJobFilter