Fix creating RPM packages #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, doesn't really do much right now since it's just one file being compiled - but maybe it will matter in the future. Also make it so the "install" command doesn't actually build anything, and just installs. Update the README to promote usage of the build.sh script Also remove the installation instruction for PyPi - it's not up there yet.
Just do a recursive include of all .pyx .pxd .pxi .h files
tazend
added a commit
that referenced
this pull request
Jan 19, 2023
* update the build-script to allow parallel builds Well, doesn't really do much right now since it's just one file being compiled - but maybe it will matter in the future. Also make it so the "install" command doesn't actually build anything, and just installs. Update the README to promote usage of the build.sh script Also remove the installation instruction for PyPi - it's not up there yet. * fix bdist_rpm not including pyslurm.pyx Just do a recursive include of all .pyx .pxd .pxi .h files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the creation of RPM packages (with bdist_rpm) which didn't work because
pyslurm.pyxwasn't actually included in the tar file that rpmbuild uses to create the RPM - also removes the python-nose, python-sphinx and Cython build-requirements, I think it is fine enough when a virtualenv is used with these installed during build time.Also makes it so the
python setup.py installactually only installs again and doesn't do any compilation.And update the
build.shscript to allow usage of multiple cores when building (even though there is no real benefit yet, since there is only one file that needs to be compiled right now - but maybe sometime in the future it will help)Closes #246