fix: cross-compilation compatibility checks for Windows #4800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
davidhewitt
approved these changes
Dec 31, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, will rebase my PR after this merges 👍
davidhewitt
pushed a commit
that referenced
this pull request
Jan 3, 2025
* fix: cross-compilation compatibility checks for Windows * add newsfragments * add simple test
davidhewitt
pushed a commit
that referenced
this pull request
Jan 11, 2025
* fix: cross-compilation compatibility checks for Windows * add newsfragments * add simple test
JeanArhancet
pushed a commit
to JeanArhancet/pyo3
that referenced
this pull request
Jan 17, 2025
* fix: cross-compilation compatibility checks for Windows * add newsfragments * add simple test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyo3-build-confighas anis_cross_compiling_from_tocheck which returnsfalsewhen compiling for 32-bit on 64-bit Windows, but the check doesn't take Windows on Arm into consideration and simply returnsfalsewhen bothhostandtargetare Windows, resulting in compilation failure when cross-compiling for aarch64 on x86-64 Windows.This PR fixes the check according to the original comment, and
marutin build --target aarch64-pc-windows-msvcworks as expected on x86-64 Windows with MSVC toolchain.Related Issue: PyO3/maturin#2368
I wonder if this PR should be merged with #4773.