Add support for Apple Silicon macOS #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target whl filename will include binary format string `macosx_11_0_arm64` as indicated in the CPython packaging PR that added support for Apple Silicon: pypa/packaging#319 The dot so file will have the same extension suffix as x86_64 darwin, specified at https://docs.python.org/3/whatsnew/3.5.html#build-and-c-api-changes Updated `platforms` crates to 1.1.0 to include the PR for apple silicon support, so that guessing platform will not throw an unsupported error. Ref: https://github.com/RustSec/platforms-crate/pull/32 Signed-off-by: LER0ever <[email protected]>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for building and developing PyO3 extensions in macOS on Apple Silicon (aarch64-apple-darwin).
Before this PR, maturin gives out an error while guessing the current architecture on arm64 mac.
This PR includes:
platformscrate to 1.1.0 to include support for Apple Silicon macOS: https://github.com/RustSec/platforms-crate/pull/32macosx_11_0_arm64, ref: add support for macos 11.0, arm64, universal2 pypa/packaging#319darwin, ref: https://docs.python.org/3/whatsnew/3.5.html#build-and-c-api-changesThis PR does NOT include Universal 2 binary format support, and only produces native arm64 binary wheels on M1 machines.
A screenshot of before and after: