Skip to content

Adds support for system account lookup #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2021
Merged

Adds support for system account lookup #478

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b4afc3
Adds support for system account lookup
bkatyl Mar 2, 2021
7b4ab1f
Adding if statement body and () for readability
bkatyl Mar 18, 2021
7b702a8
Update pwd.c
bagajjal Mar 23, 2021
17ab16a
resolve merge conflicts after fetching latest changes
bagajjal Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions contrib/win32/win32compat/pwd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,11 @@ get_passwd(const wchar_t * user_utf16, PSID sid)
goto cleanup;
}

/* If standard local user name, just use name without decoration */
if ((_wcsicmp(domain_name, computer_name) == 0) && (_wcsicmp(computer_name, user_name) != 0))
/* if standard local user name or system account, just use name without decoration */
const SID_IDENTIFIER_AUTHORITY nt_authority = SECURITY_NT_AUTHORITY;
if ((_wcsicmp(domain_name, computer_name) == 0) && (_wcsicmp(computer_name, user_name) != 0) ||
((memcmp(&nt_authority, GetSidIdentifierAuthority((PSID)binary_sid), sizeof(SID_IDENTIFIER_AUTHORITY)) == 0) && (
((SID*)binary_sid)->SubAuthority[0] == SECURITY_LOCAL_SYSTEM_RID)))
wcscpy_s(user_resolved, ARRAYSIZE(user_resolved), user_name);

/* put any other format in sam compatible format */
Expand Down