Skip to content

Clean up breakpoint files #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2022
Merged

Clean up breakpoint files #1701

merged 1 commit into from
Feb 10, 2022

Conversation

andyleejordan
Copy link
Member

Roslynator suggestions and small fixes.

@andyleejordan andyleejordan added the Ignore Exclude from the changelog. label Feb 9, 2022
JamesWTruher
JamesWTruher approved these changes Feb 10, 2022
View reviewed changes
Copy link

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PaulHigin
PaulHigin approved these changes Feb 10, 2022
View reviewed changes
Copy link

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/PowerShellEditorServices/Services/DebugAdapter/BreakpointService.cs
}
CommandBreakpoint commandBreakpoint => CommandBreakpoints.Remove(commandBreakpoint),
LineBreakpoint lineBreakpoint =>
BreakpointsPerFile.TryGetValue(lineBreakpoint.Script, out HashSet<Breakpoint> bps) && bps.Remove(lineBreakpoint),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little too sparse for me.

@andyleejordan andyleejordan merged commit d9e6fb5 into master Feb 10, 2022
@andyleejordan andyleejordan deleted the andschwa/breakpoint-cleanup branch February 10, 2022 17:50
@andyleejordan
Copy link
Member Author

Thanks ya'll!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

2 more reviewers

@JamesWTruher JamesWTruher JamesWTruher approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Ignore Exclude from the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyleejordan @JamesWTruher @PaulHigin