Skip to content

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Dec 28, 2021

I was fortunately able to re-enable the PowerShellContextService tests with the new PsesInternalHost pretty easily.

Also fixes PowerShell/vscode-powershell#3677.

@andyleejordan
Copy link
Member Author

Oops, gotta fix it for Windows 🤷

@andyleejordan andyleejordan force-pushed the andschwa/pses-host-tests branch from 7c1a5cc to cceedab Compare December 28, 2021 21:36
@andyleejordan
Copy link
Member Author

All fixed!

@andyleejordan
Copy link
Member Author

Hey @JustinGrote I covered #1629 with a regression test and cherry-picked the commit. Can you review this? We can close the other PR.

@andyleejordan andyleejordan force-pushed the andschwa/pses-host-tests branch from c03154e to 76a5791 Compare December 28, 2021 23:20
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! + one question

@andyleejordan andyleejordan force-pushed the andschwa/pses-host-tests branch from 76a5791 to 0903b6a Compare January 3, 2022 04:07
@andyleejordan andyleejordan force-pushed the andschwa/pses-host-tests branch from 0903b6a to 57bdb36 Compare January 5, 2022 16:58
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan
Copy link
Member Author

Part of #1677

@andyleejordan andyleejordan mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Terminating Exceptions not handled correctly, throw REPL ArgumentOutOfRangeException
3 participants