Skip to content

Remove comment and simplify condition in WebCmdlets #19251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Remove comment and simplify condition in WebCmdlets #19251

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d951f1a
remove wrong comment
CarloToso Mar 1, 2023
b12674d
conditional ContentLength
CarloToso Mar 1, 2023
1df8efe
revert
CarloToso Mar 1, 2023
da3d5c3
follow suggestion
CarloToso Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...owerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,11 +902,9 @@ internal virtual void PrepareSession()
{
webProxy.Credentials = ProxyCredential.GetNetworkCredential();
}
else if (ProxyUseDefaultCredentials)
else
{
// If both ProxyCredential and ProxyUseDefaultCredentials are passed,
// UseDefaultCredentials will overwrite the supplied credentials.
webProxy.UseDefaultCredentials = true;
webProxy.UseDefaultCredentials = ProxyUseDefaultCredentials;
}

WebSession.Proxy = webProxy;
Expand Down