Add back Get-Counter cmdlet for Windows

[SteveL-MSFT]

PR Summary

Reviewed the APIs being used. Get-Counter can work with just public APIs published in pdh.h. Import-Counter and Export-Counter rely on undocumented APIs so those are removed. The PDH apis are really old so I don't believe there's any chance to get those APIs or the binary log format documented so removed that code. Get-Counter -ListSet has Description property as empty because it isn't supported by PDH apis.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed: Bring back doc for Get-Counter cmdlet for PS7 MicrosoftDocs/PowerShell-Docs#5020
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[SteveL-MSFT]

@sdwheeler new fwlink for Get-Counter?

[sdwheeler]

@SteveL-MSFT https://go.microsoft.com/fwlink/?linkid=2109647

Get-Counter (Microsoft.PowerShell.Diagnostics)

The Get-Counter cmdlet gets performance counter data directly from the performance monitoring instrumentation in the Windows family of operating systems. Get-Counter gets performance data from a local computer or remote computers. You can use the Get-Counter parameters to specify one or more computers, list the performance counter sets and the instances they contain, set the sample intervals, and specify the maximum number of samples. Without parameters, Get-Counter gets performance counter data for a set of system counters. Many counter sets are protected by access control lists (ACL). To see all counter sets, open PowerShell with the Run as administrator option.

[iSazonov]

I found https://github.com/microsoft/Tx. It seems work with blg.

[SteveL-MSFT]

@iSazonov nice find, seems that Tx is using a different set of APIs to read the log, not sure if there is a different public api to write the binary log. I suggest we defer this for now.

[iSazonov]

I suggest we defer this for now.

Maybe open a tracking issue if you plan to investigate this?

[SteveL-MSFT]

@iSazonov created #10946

[TravisEz13]

@SteveL-MSFT Can you run a coordinated package build and send me a Direct Message with the build information? Let's verify this doesn't cause any new compliance issues.

[ghost]

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes