Skip to content

Have a single point of reference for the .Net Core SDK version #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2018
Merged

Have a single point of reference for the .Net Core SDK version #885

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d68c966
Have a single point of reference for the .Net Core SDK version
bergmeister Feb 10, 2018
1e81cb0
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Feb 19, 2018
b25ffc8
update syntax for WMF4 due to a breaking change in the integration of…
bergmeister Feb 19, 2018
22a797a
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ install:
}
- ps: |
# the legacy WMF4 image only has the old preview SDKs of dotnet
if (-not ((dotnet --version).StartsWith('2.1.4')))
$globalDotJson = Get-Content .\global.json -Raw | ConvertFrom-Json
$dotNetCoreSDKVersion = $globalDotJson.sdk.version
if (-not ((dotnet --version).StartsWith($dotNetCoreSDKVersion)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be specifying a specific version or just ensuring that the dotnet version is high enough?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on this to be honest but if we regularly keep up with the latest SDKs we should not fall behind the versions in the Appveyor images any more. It's probably best to revisit when some of this code gets moved into build modules

{
Invoke-WebRequest 'https://dot.net/v1/dotnet-install.ps1' -OutFile dotnet-install.ps1
.\dotnet-install.ps1 -Version 2.1.4
.\dotnet-install.ps1 -Version $dotNetCoreSDKVersion
}

build_script:
Expand Down