Skip to content

Correct the default foreground/background colors #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

Correct the default foreground/background colors #1435

merged 1 commit into from
Mar 30, 2020

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Mar 30, 2020 •
edited
Loading

A couple of minor fixes

  • Correct the default foreground/background colors, so the default color for selection text on macOS can be fixed. Fix Selected text are hard to tell on Linux and macOS #1411
  • Add CheckForOverflowUnderflow property to enable arithmetic overflow checking
  • Ignore .ionide folders. They are folders to hold the symbol caches for VSCode C# extension
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit 8b778c6 into PowerShell:master Mar 30, 2020
@daxian-dbw daxian-dbw deleted the minor branch March 30, 2020 22:43
@daxian-dbw
Copy link
Member Author

@lzybkr @SteveL-MSFT Just for your information, I will release the version 2.0.1 after getting #1298 in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

1 more reviewer

@lzybkr lzybkr lzybkr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selected text are hard to tell on Linux and macOS
2 participants
@daxian-dbw @lzybkr