Skip to content

Ensure the desired column number is used while moving up or down in VI mode #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2019
Merged

Ensure the desired column number is used while moving up or down in VI mode #1122

merged 2 commits into from
Dec 9, 2019

Conversation

springcomp
Copy link
Contributor

Fixes #1121.

@springcomp springcomp changed the title In VI mode, the desired column number is not always enforced while moving up or down Ensure the desired column number is using while moving up or down in VI mode Oct 24, 2019
@springcomp springcomp changed the title Ensure the desired column number is using while moving up or down in VI mode Ensure the desired column number is used while moving up or down in VI mode Oct 24, 2019
@springcomp
In VI mode up or down, cursor should stick to desired column number u…
47e26a4 
…nless explicit end of line.

# Conflicts:
#	test/MovementTest.VI.Multiline.cs
daxian-dbw
daxian-dbw reviewed Dec 9, 2019
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that it takes forever to review this PR. It overall looks good to me. I left 2 comments, please take a look when you get a chance.

@daxian-dbw daxian-dbw merged commit 9ad8eb6 into PowerShell:master Dec 9, 2019
@springcomp springcomp deleted the #1121 branch December 9, 2019 22:13
@springcomp springcomp mentioned this pull request Jan 19, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In VI mode, the cursor does not always stick to the desired column number
2 participants
@springcomp @daxian-dbw