Skip to content

Fix GenerateRender #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2019
Merged

Fix GenerateRender #1049

merged 3 commits into from
Sep 16, 2019

Conversation

daxian-dbw
Copy link
Member

Fix #911

Fix two issues:

  1. process $a\b results in IndexOutOfRangeException. Fixed by the continue change.
  2. process out results in NullReferenceException. Fixed by the break change.

/cc @msftrncs

@daxian-dbw daxian-dbw requested a review from lzybkr September 15, 2019 05:30
@daxian-dbw daxian-dbw mentioned this pull request Sep 16, 2019
Closed
@daxian-dbw
Copy link
Member Author

PR was updated to favor @msftrncs's changes in #1050
Added additional comments and tests.

@daxian-dbw daxian-dbw merged commit 2e12332 into PowerShell:master Sep 16, 2019
@daxian-dbw daxian-dbw deleted the genRender branch September 16, 2019 20:21
@msftrncs
Copy link
Collaborator

LGTM, I've set this build to be my active version.

@daxian-dbw daxian-dbw mentioned this pull request Sep 30, 2019
Closed
@msftrncs msftrncs mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzybkr lzybkr Awaiting requested review from lzybkr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when deleting text from start-process command
2 participants
@daxian-dbw @msftrncs